aboutsummaryrefslogtreecommitdiffstats
path: root/lib/rss/rss.rb
diff options
context:
space:
mode:
authorkou <kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-10-22 16:03:57 +0000
committerkou <kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-10-22 16:03:57 +0000
commit5e648821233fa9aedeeb50e7c6c048550860298d (patch)
tree02fa443fef401cd141410133be83e22be20547bc /lib/rss/rss.rb
parent588ac3ee1fd23690e2da36986f736aac12bec589 (diff)
downloadruby-5e648821233fa9aedeeb50e7c6c048550860298d.tar.gz
rss itunes: fix a bug that <itunes:explicit> value isn't fully supported
Fix GH-1725 <itunes:explicit> accepts "explicit", "yes", "true", "clean", "no" and "false" as valid values. Here is the <itunes:explicit>'s description in https://help.apple.com/itc/podcasts_connect/#/itcb54353390: > The <itunes:explicit> tag indicates whether your podcast contains > explicit material. You can specify the following values: > > * Yes | Explicit | True. If you specify yes, explicit, or true, > indicating the presence of explicit content, the iTunes Store > displays an Explicit parental advisory graphic for your podcast. > > * Clean | No | False. If you specify clean, no, or false, indicating > that none of your podcast episodes contain explicit language or > adult content, the iTunes Store displays a Clean parental > advisory graphic for your podcast. I don't know whether <itunes:explicit> value is case sensitive or insensitive. But the current implementation is case insensitive. Reported by Valerie Woolard Srinivasan. Thanks!!! git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'lib/rss/rss.rb')
-rw-r--r--lib/rss/rss.rb14
1 files changed, 7 insertions, 7 deletions
diff --git a/lib/rss/rss.rb b/lib/rss/rss.rb
index 00db219d4e..f88bb3c1ba 100644
--- a/lib/rss/rss.rb
+++ b/lib/rss/rss.rb
@@ -374,12 +374,12 @@ EOC
end
end
- def yes_clean_other_attr_reader(*attrs)
+ def explicit_clean_other_attr_reader(*attrs)
attrs.each do |attr|
module_eval(<<-EOC, __FILE__, __LINE__ + 1)
attr_reader(:#{attr})
def #{attr}?
- YesCleanOther.parse(@#{attr})
+ ExplicitCleanOther.parse(@#{attr})
end
EOC
end
@@ -544,7 +544,7 @@ EOC
EOC
end
- def yes_clean_other_writer(name, disp_name=name)
+ def explicit_clean_other_writer(name, disp_name=name)
module_eval(<<-EOC, __FILE__, __LINE__ + 1)
def #{name}=(value)
value = (value ? "yes" : "no") if [true, false].include?(value)
@@ -763,8 +763,8 @@ EOC
text_type_writer name, disp_name
when :content
content_writer name, disp_name
- when :yes_clean_other
- yes_clean_other_writer name, disp_name
+ when :explicit_clean_other
+ explicit_clean_other_writer name, disp_name
when :yes_other
yes_other_writer name, disp_name
when :csv
@@ -782,8 +782,8 @@ EOC
inherit_convert_attr_reader name
when :uri
uri_convert_attr_reader name
- when :yes_clean_other
- yes_clean_other_attr_reader name
+ when :explicit_clean_other
+ explicit_clean_other_attr_reader name
when :yes_other
yes_other_attr_reader name
when :csv