diff options
| author | Olle Jonsson <olle.jonsson@auctionet.com> | 2020-04-19 18:06:02 +0200 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-06-05 07:32:42 +0900 |
| commit | f61ee674d8c5871e8e81b1a7f5884635a0ee9803 (patch) | |
| tree | aa956731f75c20eaa39b7366d0428155df685a77 /lib/rubygems/command.rb | |
| parent | dd5b918cbead5fdb641118aa4e4d90e013f90df1 (diff) | |
| download | ruby-f61ee674d8c5871e8e81b1a7f5884635a0ee9803.tar.gz | |
[rubygems/rubygems] Prefer start_with? and end_with? over regex.
- In one of the cases, filenames were checked for ending with "gz" -
this is changed to check for ending with ".gz"
- The change was made to make it even easier to read the code, and to
match only from the start of the input (as opposed to start of the
line)
https://github.com/rubygems/rubygems/commit/aac4290271
Diffstat (limited to 'lib/rubygems/command.rb')
| -rw-r--r-- | lib/rubygems/command.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/rubygems/command.rb b/lib/rubygems/command.rb index 2fb3dab2fe..088f4add99 100644 --- a/lib/rubygems/command.rb +++ b/lib/rubygems/command.rb @@ -456,7 +456,9 @@ class Gem::Command until extra.empty? do ex = [] ex << extra.shift - ex << extra.shift if extra.first.to_s =~ /^[^-]/ + if (!extra.first.to_s.empty? && !extra.first.to_s.start_with?("-")) + ex << extra.shift + end result << ex if handles?(ex) end |