diff options
author | Jean Boussier <byroot@ruby-lang.org> | 2024-03-03 10:46:46 +0100 |
---|---|---|
committer | Peter Zhu <peter@peterzhu.ca> | 2024-03-06 15:33:43 -0500 |
commit | d4f3dcf4dff80ded472ba3061e62c6c676ffab8c (patch) | |
tree | 4dd0954969e05925932b38ebd275d125f2304339 /mini_builtin.c | |
parent | 16ec54ec4177f959b6912745460fd6a96d906d82 (diff) | |
download | ruby-d4f3dcf4dff80ded472ba3061e62c6c676ffab8c.tar.gz |
Refactor VM root modules
This `st_table` is used to both mark and pin classes
defined from the C API. But `vm->mark_object_ary` already
does both much more efficiently.
Currently a Ruby process starts with 252 rooted classes,
which uses `7224B` in an `st_table` or `2016B` in an `RArray`.
So a baseline of 5kB saved, but since `mark_object_ary` is
preallocated with `1024` slots but only use `405` of them,
it's a net `7kB` save.
`vm->mark_object_ary` is also being refactored.
Prior to this changes, `mark_object_ary` was a regular `RArray`, but
since this allows for references to be moved, it was marked a second
time from `rb_vm_mark()` to pin these objects.
This has the detrimental effect of marking these references on every
minors even though it's a mostly append only list.
But using a custom TypedData we can save from having to mark
all the references on minor GC runs.
Addtionally, immediate values are now ignored and not appended
to `vm->mark_object_ary` as it's just wasted space.
Diffstat (limited to 'mini_builtin.c')
-rw-r--r-- | mini_builtin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mini_builtin.c b/mini_builtin.c index 8371073f28..a93a5ebddb 100644 --- a/mini_builtin.c +++ b/mini_builtin.c @@ -51,7 +51,7 @@ builtin_iseq_load(const char *feature_name, const struct rb_builtin_function *ta #ifndef INCLUDED_BY_BUILTIN_C st_insert(loaded_builtin_table, (st_data_t)feature_name, (st_data_t)iseq); - rb_gc_register_mark_object((VALUE)iseq); + rb_vm_register_global_object((VALUE)iseq); #endif return iseq; |