diff options
| author | Takashi Kokubun <takashikkbn@gmail.com> | 2020-06-25 23:27:46 -0700 |
|---|---|---|
| committer | Takashi Kokubun <takashikkbn@gmail.com> | 2020-06-25 23:33:08 -0700 |
| commit | 7982dc1dfd5df000b7361ccb7bc820da4f3547b8 (patch) | |
| tree | 05b02859c3fd1654bcf3b787f2966e411848d189 /mjit_compile.c | |
| parent | 9dbc2294a6c35f201d9a05d8b02f818c05d6f399 (diff) | |
| download | ruby-7982dc1dfd5df000b7361ccb7bc820da4f3547b8.tar.gz | |
Decide JIT-ed insn based on cached cfunc
for opt_* insns.
opt_eq handles rb_obj_equal inside opt_eq, and all other cfunc is
handled by opt_send_without_block. Therefore we can't decide which insn
should be generated by checking whether it's cfunc cc or not.
```
$ benchmark-driver -v --rbenv 'before --jit;after --jit' benchmark/mjit_opt_cc_insns.yml --repeat-count=4
before --jit: ruby 2.8.0dev (2020-06-26T05:21:43Z master 9dbc2294a6) +JIT [x86_64-linux]
after --jit: ruby 2.8.0dev (2020-06-26T06:30:18Z master 75cece1b0b) +JIT [x86_64-linux]
last_commit=Decide JIT-ed insn based on cached cfunc
Calculating -------------------------------------
before --jit after --jit
mjit_nil?(1) 73.878M 74.021M i/s - 40.000M times in 0.541432s 0.540391s
mjit_not(1) 72.635M 74.601M i/s - 40.000M times in 0.550702s 0.536187s
mjit_eq(1, nil) 7.331M 7.445M i/s - 8.000M times in 1.091211s 1.074596s
mjit_eq(nil, 1) 49.450M 64.711M i/s - 8.000M times in 0.161781s 0.123627s
Comparison:
mjit_nil?(1)
after --jit: 74020528.4 i/s
before --jit: 73878185.9 i/s - 1.00x slower
mjit_not(1)
after --jit: 74600882.0 i/s
before --jit: 72634507.6 i/s - 1.03x slower
mjit_eq(1, nil)
after --jit: 7444657.4 i/s
before --jit: 7331304.3 i/s - 1.02x slower
mjit_eq(nil, 1)
after --jit: 64710790.6 i/s
before --jit: 49449507.4 i/s - 1.31x slower
```
Diffstat (limited to 'mjit_compile.c')
| -rw-r--r-- | mjit_compile.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/mjit_compile.c b/mjit_compile.c index b2e40828b6..8ceab558dd 100644 --- a/mjit_compile.c +++ b/mjit_compile.c @@ -105,9 +105,11 @@ has_valid_method_type(CALL_CACHE cc) // Returns true if MJIT thinks this cc's opt_* insn may fallback to opt_send_without_block. static bool -has_cache_for_send(CALL_CACHE cc, bool cfunc_cached) +has_cache_for_send(CALL_CACHE cc, int insn) { - return has_valid_method_type(cc) && (!cfunc_cached || vm_cc_cme(cc)->def->type != VM_METHOD_TYPE_CFUNC); + extern bool rb_vm_opt_cfunc_p(CALL_CACHE cc, int insn); + return has_valid_method_type(cc) && + !(vm_cc_cme(cc)->def->type == VM_METHOD_TYPE_CFUNC && rb_vm_opt_cfunc_p(cc, insn)); } // Returns true if iseq can use fastpath for setup, otherwise NULL. This becomes true in the same condition |