diff options
author | Kevin Newton <kddnewton@gmail.com> | 2023-10-23 12:30:14 -0400 |
---|---|---|
committer | Kevin Newton <kddnewton@gmail.com> | 2023-10-26 14:58:55 -0400 |
commit | 82acca915afedbef22d1a791fac43f50c71294d5 (patch) | |
tree | e7ede2bc57929a1ebd51b2454b11a372bbc90024 /prism | |
parent | 234e8fb819f0fc1d6f05a02976ae1c01e6cace2d (diff) | |
download | ruby-82acca915afedbef22d1a791fac43f50c71294d5.tar.gz |
[ruby/prism] Ensure no extra multi-target nodes are created
https://github.com/ruby/prism/commit/ec31fd827f
Diffstat (limited to 'prism')
-rw-r--r-- | prism/parser.h | 1 | ||||
-rw-r--r-- | prism/prism.c | 17 |
2 files changed, 14 insertions, 4 deletions
diff --git a/prism/parser.h b/prism/parser.h index f77d8818aa..c701e595a9 100644 --- a/prism/parser.h +++ b/prism/parser.h @@ -212,6 +212,7 @@ typedef enum { PM_CONTEXT_EMBEXPR, // an interpolated expression PM_CONTEXT_ENSURE, // an ensure statement PM_CONTEXT_FOR, // a for loop + PM_CONTEXT_FOR_INDEX, // a for loop's index PM_CONTEXT_IF, // an if statement PM_CONTEXT_LAMBDA_BRACES, // a lambda expression with braces PM_CONTEXT_LAMBDA_DO_END, // a lambda expression with do..end diff --git a/prism/prism.c b/prism/prism.c index 6b9c20a4bd..5cb18a7b30 100644 --- a/prism/prism.c +++ b/prism/prism.c @@ -40,6 +40,7 @@ debug_context(pm_context_t context) { case PM_CONTEXT_BLOCK_BRACES: return "BLOCK_BRACES"; case PM_CONTEXT_BLOCK_KEYWORDS: return "BLOCK_KEYWORDS"; case PM_CONTEXT_FOR: return "FOR"; + case PM_CONTEXT_FOR_INDEX: return "FOR_INDEX"; case PM_CONTEXT_IF: return "IF"; case PM_CONTEXT_MAIN: return "MAIN"; case PM_CONTEXT_MODULE: return "MODULE"; @@ -5602,6 +5603,8 @@ context_terminator(pm_context_t context, pm_token_t *token) { case PM_CONTEXT_FOR: case PM_CONTEXT_ENSURE: return token->type == PM_TOKEN_KEYWORD_END; + case PM_CONTEXT_FOR_INDEX: + return token->type == PM_TOKEN_KEYWORD_IN; case PM_CONTEXT_CASE_WHEN: return token->type == PM_TOKEN_KEYWORD_WHEN || token->type == PM_TOKEN_KEYWORD_END || token->type == PM_TOKEN_KEYWORD_ELSE; case PM_CONTEXT_CASE_IN: @@ -9585,7 +9588,7 @@ parse_target(pm_parser_t *parser, pm_node_t *target) { } } -// Parse a write targets and validate that it is in a valid position for +// Parse a write target and validate that it is in a valid position for // assignment. static pm_node_t * parse_target_validate(pm_parser_t *parser, pm_node_t *target) { @@ -12544,10 +12547,13 @@ parse_expression_prefix(pm_parser_t *parser, pm_binding_power_t binding_power) { multi_target->base.location.end = rparen_loc.end; if (match1(parser, PM_TOKEN_COMMA)) { - return parse_targets_validate(parser, (pm_node_t *) multi_target, PM_BINDING_POWER_INDEX); - } else { - return parse_target_validate(parser, (pm_node_t *) multi_target); + if (binding_power == PM_BINDING_POWER_STATEMENT) { + return parse_targets_validate(parser, (pm_node_t *) multi_target, PM_BINDING_POWER_INDEX); + } + return (pm_node_t *) multi_target; } + + return parse_target_validate(parser, (pm_node_t *) multi_target); } // If we have a single statement and are ending on a right parenthesis @@ -13634,7 +13640,9 @@ parse_expression_prefix(pm_parser_t *parser, pm_binding_power_t binding_power) { parser_lex(parser); pm_token_t for_keyword = parser->previous; pm_node_t *index; + pm_parser_scope_push_transparent(parser); + context_push(parser, PM_CONTEXT_FOR_INDEX); // First, parse out the first index expression. if (accept1(parser, PM_TOKEN_USTAR)) { @@ -13660,6 +13668,7 @@ parse_expression_prefix(pm_parser_t *parser, pm_binding_power_t binding_power) { index = parse_target(parser, index); } + context_pop(parser); pm_parser_scope_pop(parser); pm_do_loop_stack_push(parser, true); |