aboutsummaryrefslogtreecommitdiffstats
path: root/process.c
diff options
context:
space:
mode:
author卜部昌平 <shyouhei@ruby-lang.org>2020-06-16 12:27:33 +0900
committer卜部昌平 <shyouhei@ruby-lang.org>2020-06-29 11:05:41 +0900
commit92986313161c36157187ed7078fc4909bbf9bc04 (patch)
treeea653f7f1d4d8c264e2ace96944ce05c5b88e47b /process.c
parent2bfac015d3742408d0c4d9f2220413992d0e49c6 (diff)
downloadruby-92986313161c36157187ed7078fc4909bbf9bc04.tar.gz
check_exec_redirect_fd: do not goto into a branch
I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
Diffstat (limited to 'process.c')
-rw-r--r--process.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/process.c b/process.c
index 5e47a518c5..054c303679 100644
--- a/process.c
+++ b/process.c
@@ -1886,8 +1886,7 @@ check_exec_redirect_fd(VALUE v, int iskey)
fd = fptr->fd;
}
else {
- wrong:
- rb_raise(rb_eArgError, "wrong exec redirect");
+ goto wrong;
}
if (fd < 0) {
rb_raise(rb_eArgError, "negative file descriptor");
@@ -1898,6 +1897,9 @@ check_exec_redirect_fd(VALUE v, int iskey)
}
#endif
return INT2FIX(fd);
+
+ wrong:
+ rb_raise(rb_eArgError, "wrong exec redirect");
}
static VALUE