aboutsummaryrefslogtreecommitdiffstats
path: root/spec
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2020-05-24 11:20:02 +0200
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2020-06-05 07:32:42 +0900
commit0fb2a7fa1cd9348fba04e15bbc115776f4cc6d0a (patch)
tree8fc1cb7f718bb724c05eae1ae24fddd2c0275f0a /spec
parent0ae5cd55e5c764c8fb14c63eb663cdbff355434e (diff)
downloadruby-0fb2a7fa1cd9348fba04e15bbc115776f4cc6d0a.tar.gz
Fix `bin/rake spec:realworld:record`
Previously it was failing and not recording. Also, the `BUNDLER_SPEC_FORCE_RECORD` environment variable was forcing every request to be recorded, including duplicated requests to the same endpoint. That meant the recorded `versions` file would be incorrect because it would contain the result of the last request, which would be `304 NOT MODIFIED`. So, to rerecord, delete cassettes and let them be recorded when needed.
Diffstat (limited to 'spec')
-rw-r--r--spec/bundler/support/artifice/vcr.rb1
1 files changed, 0 insertions, 1 deletions
diff --git a/spec/bundler/support/artifice/vcr.rb b/spec/bundler/support/artifice/vcr.rb
index 150436f0e3..19670287b3 100644
--- a/spec/bundler/support/artifice/vcr.rb
+++ b/spec/bundler/support/artifice/vcr.rb
@@ -31,7 +31,6 @@ class BundlerVCRHTTP < Net::HTTP
def recorded_response?
return true if ENV["BUNDLER_SPEC_PRE_RECORDED"]
- return false if ENV["BUNDLER_SPEC_FORCE_RECORD"]
request_pair_paths.all? {|f| File.exist?(f) }
end