diff options
author | David Rodriguez <deivid.rodriguez@riseup.net> | 2023-09-25 16:26:06 +0200 |
---|---|---|
committer | git <svn-admin@ruby-lang.org> | 2023-09-27 03:29:37 +0000 |
commit | 57c3e45ee8d43c401ff1e52105ecbca2bd4e7550 (patch) | |
tree | be278ed84e64594ee087731773328aa9b727a047 /spec | |
parent | 705bd6439de07db1502d2fc3ac6e13ae449fc12e (diff) | |
download | ruby-57c3e45ee8d43c401ff1e52105ecbca2bd4e7550.tar.gz |
[rubygems/rubygems] Fix `bundle lock --minor --update <dep>` edge case
When the latest allowed minor of `dep` adds a new dependency, that new
dependency would be incorrectly resolved to the latest minor of the
first major version.
https://github.com/rubygems/rubygems/commit/fd50c9d4f3
Diffstat (limited to 'spec')
-rw-r--r-- | spec/bundler/commands/lock_spec.rb | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/spec/bundler/commands/lock_spec.rb b/spec/bundler/commands/lock_spec.rb index 76ea4178ae..40d8ebca00 100644 --- a/spec/bundler/commands/lock_spec.rb +++ b/spec/bundler/commands/lock_spec.rb @@ -289,6 +289,47 @@ RSpec.describe "bundle lock" do end end + context "conservative updates when minor update adds a new dependency" do + before do + build_repo4 do + build_gem "sequel", "5.71.0" + build_gem "sequel", "5.72.0" do |s| + s.add_dependency "bigdecimal", ">= 0" + end + build_gem "bigdecimal", %w[1.4.4 3.1.4] + end + + gemfile <<~G + source "#{file_uri_for(gem_repo4)}" + gem 'sequel' + G + + lockfile <<~L + GEM + remote: #{file_uri_for(gem_repo4)}/ + specs: + sequel (5.71.0) + + PLATFORMS + ruby + + DEPENDENCIES + sequel + + BUNDLED WITH + #{Bundler::VERSION} + L + + allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile) + end + + it "adds the latest version of the new dependency" do + bundle "lock --minor --update sequel" + + expect(the_bundle.locked_gems.specs.map(&:full_name)).to eq(%w[sequel-5.72.0 bigdecimal-3.1.4].sort) + end + end + it "updates the bundler version in the lockfile to the latest bundler version" do build_repo4 do build_gem "bundler", "55" |