[ruby/prism] Fix and reuse pm_call_node_index_p

Fix https://github.com/ruby/prism/pull/1925
Fix https://github.com/ruby/prism/pull/1927

Previously pm_call_node_index_p does not check about a block argument
correctly and is not used in parse_write to check an index call node.

This commit fixes these problems.

https://github.com/ruby/prism/commit/92bab044ff

1 files changed, 27 insertions, 0 deletions

diff --git a/test/prism/errors_test.rb b/test/prism/errors_test.rb
index 6f6df71d14..82f50edd6e 100644
--- a/test/prism/errors_test.rb
+++ b/test/prism/errors_test.rb
@@ -1256,6 +1256,33 @@ module Prism
       ]
     end
 
+    def test_index_call_with_block_and_write
+      source = "foo[1] {} &&= 1"
+      assert_errors expression(source), source, [
+        ["Unexpected write target", 0..9],
+        ["Unexpected operator after a call with arguments", 10..13],
+        ["Unexpected operator after a call with a block", 10..13]
+      ]
+    end
+
+    def test_index_call_with_block_or_write
+      source = "foo[1] {} ||= 1"
+      assert_errors expression(source), source, [
+        ["Unexpected write target", 0..9],
+        ["Unexpected operator after a call with arguments", 10..13],
+        ["Unexpected operator after a call with a block", 10..13]
+      ]
+    end
+
+    def test_index_call_with_block_operator_write
+      source = "foo[1] {} += 1"
+      assert_errors expression(source), source, [
+        ["Unexpected write target", 0..9],
+        ["Unexpected operator after a call with arguments", 10..12],
+        ["Unexpected operator after a call with a block", 10..12]
+      ]
+    end
+
     def test_writing_numbered_parameter
       assert_errors expression("-> { _1 = 0 }"), "-> { _1 = 0 }", [
         ["_1 is reserved for a numbered parameter", 5..7]