diff options
author | Alan Wu <XrXr@users.noreply.github.com> | 2022-04-29 18:54:16 -0400 |
---|---|---|
committer | Alan Wu <XrXr@users.noreply.github.com> | 2022-05-30 13:54:22 -0400 |
commit | a687756284187887835aa345adc89b2718054e4a (patch) | |
tree | 19593deccf5df5fe758c1f9a00b616c54ec99e02 /test/ruby/test_gc_compact.rb | |
parent | 3bef9584a879e8e29baf8e7a67383679d1ffb725 (diff) | |
download | ruby-a687756284187887835aa345adc89b2718054e4a.tar.gz |
Fix use-after-free with interacting TracePoints
`vm_trace_hook()` runs global hooks before running local hooks.
Previously, we read the local hook list before running the global hooks
which led to use-after-free when a global hook frees the local hook
list. A global hook can do this by disabling a local TracePoint, for
example.
Delay local hook list loading until after running the global hooks.
Issue discovered by Jeremy Evans in GH-5862.
[Bug #18730]
Diffstat (limited to 'test/ruby/test_gc_compact.rb')
-rw-r--r-- | test/ruby/test_gc_compact.rb | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/test/ruby/test_gc_compact.rb b/test/ruby/test_gc_compact.rb index da0023e6f3..be27199cdc 100644 --- a/test/ruby/test_gc_compact.rb +++ b/test/ruby/test_gc_compact.rb @@ -200,4 +200,21 @@ class TestGCCompact < Test::Unit::TestCase GC.compact assert_equal count + 1, GC.stat(:compact_count) end + + def test_compacting_from_trace_point + obj = Object.new + def obj.tracee + :ret # expected to emit both line and call event from one instruction + end + + results = [] + TracePoint.new(:call, :line) do |tp| + results << tp.event + GC.verify_compaction_references + end.enable(target: obj.method(:tracee)) do + obj.tracee + end + + assert_equal([:call, :line], results) + end end |