diff options
author | Aaron Patterson <aaron.patterson@gmail.com> | 2016-11-28 14:22:12 -0800 |
---|---|---|
committer | Jeremy Evans <code@jeremyevans.net> | 2019-07-30 12:03:09 -0700 |
commit | d8562ab2a40658db0e6a44ce07cfbe616b9b4078 (patch) | |
tree | 30f12370c4908438981f8bab34e0bfb2944baded /test/ruby | |
parent | 369c36ef15c15ddc297e216522cc21599ed6a8e1 (diff) | |
download | ruby-d8562ab2a40658db0e6a44ce07cfbe616b9b4078.tar.gz |
Passing `binmode: true` to `IO.pipe` should behave like `binmode`
When passing `binmode: true` to `IO.pipe`, it should behave the same way
as calling `binmode` on each of the file handles. It should set the
file to binmode *and* set the encoding to binary on the file.
Before this commit, passing `binmode: true` to `IO.pipe` would make
`binmode?` return `true`, but the file's encoding would remain the same
as the default encoding. Passing `binmode: true` should make `binmode?`
return `true` *and* set the encoding to binary.
Diffstat (limited to 'test/ruby')
-rw-r--r-- | test/ruby/test_io.rb | 32 |
1 files changed, 32 insertions, 0 deletions
diff --git a/test/ruby/test_io.rb b/test/ruby/test_io.rb index 49da709199..e633e1c600 100644 --- a/test/ruby/test_io.rb +++ b/test/ruby/test_io.rb @@ -113,6 +113,38 @@ class TestIO < Test::Unit::TestCase ].each{|thr| thr.join} end + def test_binmode_writer + EnvUtil.with_default_internal(Encoding::UTF_8) do + reader, writer = IO.pipe + reader.binmode + writer.binmode + + reader2, writer2 = IO.pipe(binmode: true) + + assert writer.binmode? + assert writer2.binmode? + assert_equal writer.binmode?, writer2.binmode? + assert_equal writer.external_encoding, writer2.external_encoding + assert_equal writer.internal_encoding, writer2.internal_encoding + end + end + + def test_binmode_reader + EnvUtil.with_default_internal(Encoding::UTF_8) do + reader, writer = IO.pipe + reader.binmode + writer.binmode + + reader2, writer2 = IO.pipe(binmode: true) + + assert reader.binmode? + assert reader2.binmode? + assert_equal reader.binmode?, reader2.binmode? + assert_equal reader.external_encoding, reader2.external_encoding + assert_equal reader.internal_encoding, reader2.internal_encoding + end + end + def test_pipe_block x = nil ret = IO.pipe {|r, w| |