diff options
| author | Takashi Kokubun <takashikkbn@gmail.com> | 2021-01-04 10:44:02 -0800 |
|---|---|---|
| committer | Takashi Kokubun <takashikkbn@gmail.com> | 2021-01-04 10:45:01 -0800 |
| commit | 87c546b5fa97e6e226cce4daf417617a1143f642 (patch) | |
| tree | 2e39443d9cadbb4fcd6fbfd2cb290a672cc9a9ca /tool/ruby_vm/views | |
| parent | e7fc353f044f9280222ca41b029b1368d2bf2fe3 (diff) | |
| download | ruby-87c546b5fa97e6e226cce4daf417617a1143f642.tar.gz | |
Avoid using inconsistent coding style
Other `_mjit_compile_*.erb` files don't use goto. These files'd better
be consistent for readability.
Diffstat (limited to 'tool/ruby_vm/views')
| -rw-r--r-- | tool/ruby_vm/views/_mjit_compile_getinlinecache.erb | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/tool/ruby_vm/views/_mjit_compile_getinlinecache.erb b/tool/ruby_vm/views/_mjit_compile_getinlinecache.erb index 1b636bceb6..637dea89e6 100644 --- a/tool/ruby_vm/views/_mjit_compile_getinlinecache.erb +++ b/tool/ruby_vm/views/_mjit_compile_getinlinecache.erb @@ -13,17 +13,10 @@ % # compiler: Capture IC values, locking getinlinecache struct iseq_inline_constant_cache_entry *ice = ic->entry; - if (ice == NULL) { - goto getinlinecache_cancel; - } - rb_serial_t ic_serial = ice->ic_serial; - const rb_cref_t *ic_cref = ice->ic_cref; - VALUE ic_value = ice->value; - - if (ic_serial && !status->compile_info->disable_const_cache) { + if (ice != NULL && ice->ic_serial && !status->compile_info->disable_const_cache) { % # JIT: Inline everything in IC, and cancel the slow path - fprintf(f, " if (vm_ic_hit_p((rb_serial_t)%"PRI_SERIALT_PREFIX"u, (const rb_cref_t *)0x%"PRIxVALUE", reg_cfp->ep)) {", ic_serial, (VALUE)ic_cref); - fprintf(f, " stack[%d] = 0x%"PRIxVALUE";\n", b->stack_size, ic_value); + fprintf(f, " if (vm_ic_hit_p((rb_serial_t)%"PRI_SERIALT_PREFIX"u, (const rb_cref_t *)0x%"PRIxVALUE", reg_cfp->ep)) {", ice->ic_serial, (VALUE)ice->ic_cref); + fprintf(f, " stack[%d] = 0x%"PRIxVALUE";\n", b->stack_size, ice->value); fprintf(f, " goto label_%d;\n", pos + insn_len(insn) + (int)dst); fprintf(f, " }"); fprintf(f, " else {"); @@ -36,4 +29,3 @@ b->stack_size += <%= insn.call_attribute('sp_inc') %>; break; } - getinlinecache_cancel:; |